Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Head Tail Bbox Updating #1345

Merged
merged 3 commits into from
May 10, 2023
Merged

Head Tail Bbox Updating #1345

merged 3 commits into from
May 10, 2023

Conversation

BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Apr 11, 2023 •
edited
Loading

resolves #1168

Changes the head/tail logic for expanding bounds:

  • If it is a new track that doesn't have a bbox yet it will use the standard padding
  • If it is an existing track and the points are moved inside of the bounds there is no adjustment to the bounding box.
  • If the points move outside of an existing bounds it will adjust to the new points with ZERO padding.

@BryonLewis BryonLewis marked this pull request as ready for review April 12, 2023 12:41
marySalvi
marySalvi approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryonLewis BryonLewis merged commit d1eb6b2 into main May 10, 2023
@BryonLewis BryonLewis deleted the head-tail-update branch May 10, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marySalvi marySalvi marySalvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If head tail points are made within a bounding box, do not adjust the bounding box size
2 participants
@BryonLewis @marySalvi