Button to boost confidence to 1.0 #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subdavis
changed the title
BryonLewis
approved these changes
Mar 29, 2022
| {{ pair[1].toFixed(4) }} | ||
| </v-col> | ||
| <v-col | ||
| v-if="pair[1] !== 1 && !disabled" |
There was a problem hiding this comment.
Just wondering if this should be shown if the pair length > 1 or if the pair[1] !== 1. I know the idea of the confidencePairs means this should never be 1.0 while also having other pairs but if anyone reformatted their CSV to have a 1.0 pair and other pairs they wouldn't be able to use this quick tool to assign a true pair. It's a small thing and probably don't worry about it too much.
There was a problem hiding this comment.
I guess it depends on what you care about. If a pair already has a value of 1.0 then maybe it doesn't matter. Likewise, if there's only one pair, but it's 0.25, maybe someone would want to make it 1.0.
We can always change it later if someone has a preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1202
This is the easy/obvious solution I could add quickly to give the user something that worked. There may be a more ergonomic version that accepts the current top confidence as correct from the track list, but I didn't do that because there's no way to show the user feedback that this has done something, and adding visual feedback will require a bit more thought.
We'll need a way to display on a track list item where
confidence == 1or not, and then a button or hotkey or something to boost it to 1. This is related to #614.I think this PR is a minimal fix that will give users something to provide feedback on.