Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassMark for Arena 0 (index 0) is skipped/not being set #38

Closed
alhasacademy96 opened this issue Jun 23, 2024 · 1 comment · Fixed by #40
Closed

PassMark for Arena 0 (index 0) is skipped/not being set #38

alhasacademy96 opened this issue Jun 23, 2024 · 1 comment · Fixed by #40
Assignees
Labels
bug fix A fix to a known bug

Comments

@alhasacademy96
Copy link
Contributor

alhasacademy96 commented Jun 23, 2024

Describe the bug
It seems to be the case where the first arena (index 0) passMark is being skipped or not being set correctly when a new configuration is called from unity.

To Reproduce
Steps to reproduce the behavior:

  1. Set passMark to any value for arena index 0
  2. Run unity by pressing play
  3. Observe the debug (already in the code in the branch)
    You will notice that whatever the passMark you set in the yaml file it will be displayed as 0 in unity debug logs. This is only the case for arena == 0.

Expected behavior
As for all other arenas defined in the yaml file, the passMark should be defined and correctly set individually and must correspond to the expected values in unity. i.e. arena = 0, passMark = 50 / expected value for passMark in unity debugs = 50.

I suspect this is related to the first arena being skipped but I can't find a connection with training mode and manual mode passMark definition.

Edit: It was to do with the arena configurations and the multiple passMark variables (one being static), which caused complexity in the logic.

Screenshots
n/a

Desktop (please complete the following information):

  • OS: WINDOWS/macOS
  • Version --> latest version of AAI unity build

Additional context
n/a

@alhasacademy96 alhasacademy96 added the bug fix A fix to a known bug label Jun 23, 2024
@alhasacademy96 alhasacademy96 self-assigned this Jun 23, 2024
Copy link

github-actions bot commented Aug 7, 2024

This issue is stale because it has been open for 45 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix A fix to a known bug
Projects
None yet
1 participant