Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/achievement cutting edge #171

Merged

Conversation

andrearosr
Copy link
Contributor

@andrearosr andrearosr commented Oct 31, 2018

Change Summary

More info

  1. The README only mentions to check Pull Requests from the list of events in order to set up the webhook, but I think this achievement would also require the Pull request reviews event, so I updated the documentation

Copy link
Member

@thatkookooguy thatkookooguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Thank you for you contribution!

One little nit:

  • maybe call the achievement Cutting Edges instead? cutting edge sounds like something positive and cutting edges sounds like an action that can be either good or bad :-)

@@ -31,7 +31,7 @@
4. click on ***add webhook***
5. paste achievibit's url (`http://achievibit.kibibit.io`) into the ***payload url***
6. change ***Content type*** to `application/json`
7. on ***Which events would you like to trigger this webhook?***, select `Let me select individual events.` and check `Pull request`
7. on ***Which events would you like to trigger this webhook?***, select `Let me select individual events.` and check `Pull request` and `Pull request reviews`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! missed this :-)

@andrearosr andrearosr force-pushed the feature/achievement-cutting-edge branch from afa7c57 to 03b4b65 Compare November 2, 2018 16:15
@andrearosr
Copy link
Contributor Author

@thatkookooguy good catch, done!

@thatkookooguy thatkookooguy merged commit e9256f0 into Kibibit:develop Nov 3, 2018
thatkookooguy pushed a commit that referenced this pull request Apr 12, 2021
* Add cutting edge tests and achievement

* Untrack yarn lock

* Update README

* Rename achievement to Cutting Edges because it sounds more dangerous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants