-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/achievement cutting edge #171
Merged
thatkookooguy
merged 4 commits into
Kibibit:develop
from
andrearosr:feature/achievement-cutting-edge
Nov 3, 2018
Merged
Feature/achievement cutting edge #171
thatkookooguy
merged 4 commits into
Kibibit:develop
from
andrearosr:feature/achievement-cutting-edge
Nov 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatkookooguy
requested changes
Nov 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Thank you for you contribution!
One little nit:
- maybe call the achievement
Cutting Edges
instead? cutting edge sounds like something positive and cutting edges sounds like an action that can be either good or bad :-)
@@ -31,7 +31,7 @@ | |||
4. click on ***add webhook*** | |||
5. paste achievibit's url (`http://achievibit.kibibit.io`) into the ***payload url*** | |||
6. change ***Content type*** to `application/json` | |||
7. on ***Which events would you like to trigger this webhook?***, select `Let me select individual events.` and check `Pull request` | |||
7. on ***Which events would you like to trigger this webhook?***, select `Let me select individual events.` and check `Pull request` and `Pull request reviews` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! missed this :-)
andrearosr
force-pushed
the
feature/achievement-cutting-edge
branch
from
November 2, 2018 16:15
afa7c57
to
03b4b65
Compare
@thatkookooguy good catch, done! |
thatkookooguy
pushed a commit
that referenced
this pull request
Apr 12, 2021
* Add cutting edge tests and achievement * Untrack yarn lock * Update README * Rename achievement to Cutting Edges because it sounds more dangerous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
More info
Pull Requests
from the list of events in order to set up the webhook, but I think this achievement would also require thePull request reviews
event, so I updated the documentation