Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_materials_transmission: Undefined function χ^- in the definition of V_T #2002

Closed
pierremoreau opened this issue Jul 14, 2021 · 1 comment · Fixed by #2007
Closed

KHR_materials_transmission: Undefined function χ^- in the definition of V_T #2002

pierremoreau opened this issue Jul 14, 2021 · 1 comment · Fixed by #2007

Comments

@pierremoreau
Copy link

In the KHR_materials_transmission extension, VT is defined as using the heaviside function χ+ in the first term, and the (AFAICT) undefined function χ- in the second term. Is the second supposed to be χ+ like in the first term, and similar to the definition of V in Appendix B of the 2.0 specification?

@proog128
Copy link
Contributor

Looks like the simplification is wrong, we need the same terms as in G_T instead. I created a pull request that fixes the issue and adds a bit of explanation. I hope it's correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants