Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Names and Component Names #109

Open
jpuigs opened this issue Dec 15, 2023 · 9 comments
Open

Service Names and Component Names #109

jpuigs opened this issue Dec 15, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@jpuigs
Copy link

jpuigs commented Dec 15, 2023

I've found a small bug.

I noticed that on all home & car receivers I have, some stations long names (16 char) are different from the ones that abracaDABra shows.
On DAB/DAB+ programs, Audio Service has a name, and Audio Component may have or not have a name.
Receivers have to look wether Audio Component has name or not, and if Audio Component has one, they have to show it, and if Audio Component has no name, they have to show the "main" name from Audio Service.

AbracaDABra always shows the Audio Service Name. It should show the component name when it's available.

On AbracaDABra ensemble info, the Service and the Component names are always the same ones, and that's the bug.
Here an example:

image

Red (service name) and Orange (Component name) are equal, but they are not really equal.
If you look at radio receiver, or you look at other PC programs like DAB Player, you'll see that names are different.

Here you have a DAB Player ensemble information, as you'll see, it shows the differences that AbracaDABra doesn't (orange Component name)

image


AbracaDABra:

image

Component name is not shown anywhere.


DAB Player:

image

So, please, would it be possible to fix the ensemble information to show correct service and component names everywhere ?
And show component name (where available) instead of Service name in main app.

Thanks,

@KejPi
Copy link
Owner

KejPi commented Dec 15, 2023

Thank you for reporting. This is actually the first time I see the primary service component to have dedicated name. I am glad that I have a test case for that and I will fix it in next version.

@KejPi
Copy link
Owner

KejPi commented Dec 16, 2023

I was checking the implementation and it is done this way intentionally because 2.1.1 standard from 2017 does not permit to broadcast primary service component name:

Snímek obrazovky 2023-12-16 v 15 00 57

Since this change could have some unwanted side effects, I have decided not to change current implementation at the moment.

@jpuigs
Copy link
Author

jpuigs commented Dec 16, 2023

OK, I understand that what is shown on the program list is OK, but inside the enseble information it should appear.
It should appear what is transmitted....

@jpuigs
Copy link
Author

jpuigs commented Dec 16, 2023

I remembered to have seen this In the UK............

image

https://assets.publishing.service.gov.uk/media/5a7adfe9ed915d71db8b3166/Domestic_Min__Spec.pdf

@jpuigs
Copy link
Author

jpuigs commented Dec 16, 2023

BBC in the UK, has 2 channels with 2 components.

image

If you always look names at service label and not on component label (if exist), you'll be listening to Parliament, and program label will be BBC Radio 4

@KejPi
Copy link
Owner

KejPi commented Dec 16, 2023

Where this comes from? My quote was taken from ETSI EN 300 401 V2.1.1 (2017-01) http://www.etsi.org/deliver/etsi_en/300400_300499/300401/02.01.01_60/en_300401v020101p.pdf

Component label is shown, but only for secondary services that shall have label unlike primary services.

@jpuigs
Copy link
Author

jpuigs commented Dec 16, 2023

OK, Ok, I know you do it correctly.
But, I repeat, although program behaviour is correctly according to ETSI standards, when we look at ensemble information, we would have to see correct component labels names, where they appear.
So, red and orange labels should appear different, as they are really transmitted different in this station and others,

image

Only here, in ensemble information .

It should not be transmitted ? Of course, It shouldn't. But as it is, we should see it exactly what is transmitted..... just for own information.

@KejPi
Copy link
Owner

KejPi commented Dec 16, 2023

I understand your point but at the moment it is not possible without side effects. The decoder is designed to be compliant with latest DAB standard so it does not consider primary service component labels. It is not a problem to decode it, after all it is label like any other - in fact it is already decoded - the problem is that at the time the service list is read from decoder it may not be available and thus the service list loading would need to be redesigned and would always take longer just to support single case. The other option would be to implement labels update functionality, that is in my TODO list, but with very low priority at the moment.

@KejPi
Copy link
Owner

KejPi commented Dec 16, 2023

Let's keep this issue open as TODO reminder like #9

@KejPi KejPi added the enhancement New feature or request label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants