Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment identifiers support #79

Open
XhmikosR opened this issue Aug 15, 2019 · 4 comments
Open

Fragment identifiers support #79

XhmikosR opened this issue Aug 15, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@XhmikosR
Copy link
Contributor

Hi, there.

So, I was wondering, would it be possible to support fragment identifiers?

I recently came into a situation which I expected linkinator to have caught. We had a link https://sass-lang.com/documentation/Sass/Script/Functions.html#quote-instance_method which redirects to https://sass-lang.com/documentation/functions. There, there's no quote-instance_method anchor.

Thanks in advance!

@XhmikosR
Copy link
Contributor Author

Hmm, visiting this with a browser it actually redirects to the proper thing. They must handle this client-side or something.

@JustinBeckwith JustinBeckwith added the enhancement New feature or request label Nov 3, 2019
@Noah-Silvera
Copy link

Just wanted to comment that I've also run into this issue!

For example, with this broken link to a missing anchor tag https://developers.geocortex.com/docs/web/api-commands-operations-events#event-ui.added.spelling.mistake, linkinator will not check the anchor fragment, but just check that https://developers.geocortex.com/docs/web/api-commands-operations-events exists, which it does.

@roydigerhund
Copy link

Is anyone by any change working on this? Or does it already work with the merge on Nov 17, 2022?

@JustinBeckwith
Copy link
Owner

That was a merge on a different repository. I haven't looked at supporting this yet (at least I don't think I did). Happy to review a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants