Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links containing search params are reported as broken #595

Open
maddsua opened this issue Mar 21, 2024 · 4 comments
Open

Links containing search params are reported as broken #595

maddsua opened this issue Mar 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@maddsua
Copy link

maddsua commented Mar 21, 2024

Simple example: a link like /checkout?services=setup-cctv would be reported as broken. Fixing this should be pretty easy tho. Gotta check the code, and I'll probably create a MR for it

@maddsua
Copy link
Author

maddsua commented Mar 21, 2024

Oh interesting, so what's broken in my case is a redirect. In fact, that /checkout page is not /checkout.html but at /checkout/index.html. But I don't feel like just slapping a regex replace on top of it, what actually fails is the file server, redirect just doesn't try to prevent it from happening and that's why adding that regex replace fixed it for me

@maddsua
Copy link
Author

maddsua commented Mar 24, 2024

So, I made a PR that fixes the issue: #596
I mean, I get that you're probably busy with more important things, but it would be nice to get this one done

@maddsua
Copy link
Author

maddsua commented Apr 5, 2024

Hey @JustinBeckwith, don't want to be annoying or anything but I think that fixing this thing is kinda important

@maddsua
Copy link
Author

maddsua commented Jun 24, 2024

Hi again! Is there any chance this fix will be merged anytime soon?
I mean, it breaks a few of my apps and I would hate to switch to a different link checker just because of that 😂
@JustinBeckwith

@JustinBeckwith JustinBeckwith added the bug Something isn't working label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants