feat: option to customize the skipped link relation types #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JustinBeckwith It would be great to get feedback on the approach, at least whether the general idea is a candidate to merge or not (it's blocking an issue we would have to approach otherwise once we know about whether it can be done in linkinator or not). Thanks ! |
|
Closing this due to lack of any feedback - would have to be restarted anyways from scratch. We're solving the problem using the new URL rewriting CLI feature now (rewriting the prod domain in the canonical header to the preview domain) but it's not ideal - we're not detecting accidental absolute links to the prod domain any more this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #175
Hi,
since the last idea in #175 turned out to be relatively simple to implement, here's a try on it. What do you think?
Nitpick: It includes a small change to the default behavior, too - expanding the "rel" filtering to all tags that are specified to support "rel" means that if someone really uses
<a href="foo" rel="prefetch" >...in their code that would now be ignored in the defaults. But since that is nonfunctional pointless HTML it's not specifically worrying me. In a very strict interpretation of semantic versioning it could be considered a breaking change though - if that's the case I would roll it back to just apply tolinktags.