Bad values if vault send error

[gyrter]

Describe the bug

Helm-vault plugin can install release with out any error with bad values, when Vault return HTTP error.

To Reproduce

Steps to reproduce the behavior:

1. Create release with a lot of values in Vault.
2. Start deploy
3. Turn off Vault during release
4. See error. For example in fount this in pull secret deploy-token:%!s(<nil>)

Expected behavior

Plugin supress vault error.

Environment:

• OS: Linux
• Python Version 3.9
• Vault Version current from master

[deniskv]

Any updates?

[Just-Insane]

Hello,

I haven't worked with this project in quite a while and no longer use Vault.

It seems like we aren't checking or handling errors when making API calls to vault. I'll have to look, but I'm pretty sure we use the vault CLI client in python, so it should be relatively easy to add error handling, I hope.

I'll take a look at this tomorrow if I have time and will update the thread.