Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unitaryPower flag for QAM power selection #13

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

daniel-s-w
Copy link
Contributor

Hey there,
as I've recently switched from MATLAB to Julia, I've discovered this nice package for digital communications simulation.
As I've tried to port some code from MATLAB, I've found that there is no way to let the QAM generator output non-normalized values in the julia package.
Thus, I've added this feature with backwards compatibility:
To be able to switch the normalization of the output power for the QAM mapping, a flag has been added. Now one can decide between unitary output values and default QAM values (-1,+1,-3,+3, ...)

Daniel

- To be able to switch the normalization of the output power for the QAM
  mapping, a flag has been added. Now one can decide between unitary
  output values and default QAM values (-1,+1,-3,+3, ...)
@RGerzaguet
Copy link
Member

Hello Daniel,

Thank you very much for this small yet value PR ;)
I agree that these kind of flexibility is interesting especially when shifting from a langage to another.
I think that we could add just some additional test to be sure everything is OK. I have added some tests on your branch but I still struggle with Github PR and it seems to have been considered as another PR 🤦.
Many thanks, it can be merged !

@RGerzaguet RGerzaguet merged commit 84f580b into JuliaTelecom:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants