Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstring update for getters functions #73

Closed
mcontim opened this issue Jan 3, 2022 · 2 comments
Closed

Docstring update for getters functions #73

mcontim opened this issue Jan 3, 2022 · 2 comments

Comments

@mcontim
Copy link

mcontim commented Jan 3, 2022

Hello!

I noticed that in the docstrings of getters functions (e.g., get_i) it is not specified that the function call with SV can be done only using the ECI frame. It's a minor detail, but specifying it in the documentation it would improve the readability of the functions.

Thank you again for your work the Toolbox is really good :)
@ronisbr
Copy link
Member

ronisbr commented Jan 8, 2022

Hi @BlueTeo91

You are 100% right! I will do this, thanks!

@sxd190026 sxd190026 mentioned this issue May 17, 2022
Closed
@ronisbr
Copy link
Member

ronisbr commented Jul 1, 2023

The API was completely modified for the upcoming split of SatelliteToolbox.jl into small modules. AFAIK, this problem does not exist anymore. Feel free to re-open if it is not the case!

@ronisbr ronisbr closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronisbr @mcontim