Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make POT optional #29

Merged
merged 7 commits into from
Dec 13, 2020
Merged

Make POT optional #29

merged 7 commits into from
Dec 13, 2020

Conversation

devmotion
Copy link
Member

This PR extends https://github.com/zsteve/OptimalTransport.jl/pull/23 and makes POT optional. A submodule POT will be available (and exported) if users load PyCall.

This fixes https://github.com/zsteve/OptimalTransport.jl/issues/18.

@coveralls
Copy link

coveralls commented Dec 12, 2020

Pull Request Test Coverage Report for Build 418805948

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 51.152%

Totals Coverage Status
Change from base Build 418497072: 0.2%
Covered Lines: 111
Relevant Lines: 217

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Dec 12, 2020

Codecov Report

Merging #29 (dfa1ccb) into master (618450e) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   50.92%   51.15%   +0.22%     
==========================================
  Files           2        3       +1     
  Lines         216      217       +1     
==========================================
+ Hits          110      111       +1     
  Misses        106      106              
Impacted Files Coverage Δ
src/OptimalTransport.jl 45.07% <100.00%> (-1.66%) ⬇️
src/pot.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618450e...dfa1ccb. Read the comment docs.

@zsteve zsteve merged commit 5a4f5a7 into JuliaOptimalTransport:master Dec 13, 2020
@devmotion devmotion deleted the python branch December 13, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Python implementation to separate package?
4 participants