Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows support #5

Closed
johnnychen94 opened this issue May 11, 2021 · 1 comment · Fixed by #6
Closed

windows support #5

johnnychen94 opened this issue May 11, 2021 · 1 comment · Fixed by #6

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented May 11, 2021

Unfortunately, the cross-compiled libsixel dll library doesn't provide one key symbol that we need: sixel_allocator_new and thus our current implementation doesn't work on Windows. A possible workaround (not yet checked) is to create our Julia version of SixelAllocator and then pass it to the C side libsixel.

@saitoha Is this an expected behavior or I did something wrong with the libsixel compilation? The build script can be found in https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/libsixel/build_tarballs.jl (cross-compiled from mingw)

all exported symbols in windows dll

WechatIMG426
WechatIMG427
WechatIMG428
WechatIMG429

@johnnychen94
Copy link
Member Author

johnnychen94 commented May 11, 2021

This turns out to be a missing SIXELAPI to sixel_allocator_new; PRs opened in both upstream libsixel(saitoha/libsixel#151) and Julia Yggdrasil(JuliaPackaging/Yggdrasil#2964) as hot-fix.

@johnnychen94 johnnychen94 removed the help wanted Extra attention is needed label May 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant