Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using jlls #107

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Move to using jlls #107

merged 2 commits into from
Mar 27, 2020

Conversation

aviks
Copy link
Contributor

@aviks aviks commented Mar 24, 2020

lower bound to Julia 1.3 as a result.

@omus
Copy link
Member

omus commented Mar 25, 2020

The CI should be configured to only run on 1.3+

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #107 into master will decrease coverage by 1.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   78.94%   77.63%   -1.32%     
==========================================
  Files           6        6              
  Lines         152      152              
==========================================
- Hits          120      118       -2     
- Misses         32       34       +2
Impacted Files Coverage Δ
src/LightXML.jl 100% <ø> (ø) ⬆️
src/nodes.jl 80.58% <0%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666caa7...768d387. Read the comment docs.

@aviks
Copy link
Contributor Author

aviks commented Mar 26, 2020

All tests now pass, except drone, which failes on armv7 1.4, which hasnt been released yet unfortunately. Would you want to keep that for future use, or disable testing on that platform?

@omus
Copy link
Member

omus commented Mar 27, 2020

I'll make an issue for it but I think we can just leave it as is for now.

@omus omus merged commit 2b5a2fb into JuliaIO:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants