Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PSFModels and fix column-orientation #59

Closed
mileslucas opened this issue Feb 7, 2022 · 0 comments · Fixed by #62
Closed

Update PSFModels and fix column-orientation #59

mileslucas opened this issue Feb 7, 2022 · 0 comments · Fixed by #62

Comments

@mileslucas
Copy link
Member

ADI.jl needs desperately updated to use PSFModels@v0.5.0, Photometry@v0.8.0, HCIDatasets@v0.3.0, and HCIToolbox@v0.6.0. These are not trivial changes- the new PSF models and injection code will require lots of line-by-line changes, I'm not sure how much are already here. Fixing the column-orientation is going to be tedious, partly because the "convenient" helpers and abstractions get really messy for LOCI and the annulus views. In addition, the documentation will need to be carefully revisited to make sure the orientation convention is consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant