Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise the workflow #5

Closed
giordano opened this issue Jan 25, 2021 · 0 comments · Fixed by #6
Closed

Reorganise the workflow #5

giordano opened this issue Jan 25, 2021 · 0 comments · Fixed by #6

Comments

@giordano
Copy link
Member

What analyze(package) now does is the following:

  • create a temporary directory (dest)
  • clone the repo inside it (dest)
  • look for all relevant files in it

I think a more flexible approach would be to

  • have an outer function which clones the repo inside the given directory (root/package-name, idea: by default root is a mktempdir, which is automatically deleted at the end of session, but the user can change it)
  • have an inner function which only looks for the relevant files inside the given directory (package-name)

For example, PkgEvaluator already has all the packages, so doesn't need to force cloning all them again. Also, this allows keeping all the repo around, to reanalyse them if necessary. As it is now, they're always all thrashed when we're done

@ericphanson ericphanson mentioned this issue Feb 9, 2021
@giordano giordano linked a pull request Feb 10, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant