Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default order-properties to sort-package-json, not legacy #58

Closed
JoshuaKGoldberg opened this issue Oct 17, 2023 · 3 comments · Fixed by #122
Closed

Default order-properties to sort-package-json, not legacy #58

JoshuaKGoldberg opened this issue Oct 17, 2023 · 3 comments · Fixed by #122
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Full Recommended ...

Comments

@JoshuaKGoldberg
Copy link
Owner

Following up on #31 -> #55: now that #55 is merged, we can look at changing the default value for the order option of the order-properties rule to "sort-package-json" instead of "legacy". This is a breaking change.
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Closed
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Jan 20, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@allcontributors @JoshuaKGoldberg
docs: add joshuakgoldberg as a contributor for ideas (#108)
de68f50 
Adds @JoshuaKGoldberg as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#58 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 20, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@JoshuaKGoldberg
feat: change order-properties order default to sort-package-json (#122)
246261d 
## PR Checklist

-   [x] Addresses an existing open issue: fixes #58
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Applies the change, along with a notice in the docs.

**This is a breaking change**. But since this package is still 0.x,
there's nothing necessary to do with semver.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.6.0 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Full Recommended Config
1 participant
@JoshuaKGoldberg