Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] tags for Acronyms #124

Open
nanometrenat opened this issue Jul 18, 2024 · 3 comments
Open

[Feature request] tags for Acronyms #124

nanometrenat opened this issue Jul 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@nanometrenat
Copy link

Hi there, following the work done for #109 and the conversation in Slack, please may you kindly introduce the concept of "tags" for the acronyms.

This means people will be able to see at a glance what the acronym relates to - e.g.

  • Scope - General / Humanitarian / Red Cross Red Crescent / Country specific / NS specific
  • Field - Medical, Geo, IT etc.
  • Specific country/org - country/NS/bit of RC etc.
  • potentially consider a language tag - allowing e.g. non-4-lang acronyms to be added

It's fine for the tags to be fairly free-form - as we tried imposing a hierarchy when doing the initial analysis and several things fell into multiple categories in the hierarchy.

Aware this is build - and there are various design options - so super-happy to talk about options that balance level of effort to implement vs maintain.

cc @ioalexei @toffehoff

@nanometrenat nanometrenat changed the title Feature request: tags for Acronyms [Feature request] tags for Acronyms Jul 18, 2024
@JonathanGarro JonathanGarro self-assigned this Jul 18, 2024
@JonathanGarro JonathanGarro added the enhancement New feature or request label Jul 18, 2024
@JonathanGarro
Copy link
Owner

@nanometrenat i've addressed some of this idea, starting with the easier things.

  • Scope: This has been added as a dropdown on the new and edit acronym pages
  • Country: This has been added as a dropdown on the new and edit acronym pages

These two were relatively easy solutions that just required adding a couple columns to the acronym table, migrating that change to production, and updating the models and Flask routes that handle reading/writing data.

I have not implemented the tagging as this involves much more overhead with new many-to-many relationships, which in turn means new tables to handle those relationships. It also means that unlike the scope and country above which have either very simple lists (former) or an existing table to reference (latter—the NationalSociety table), this would be a new system similar to how I've handled the skills list for users (which has a similar many-to-many relationship). I would need to add admin views to handle manual updates to that list if we want people to choose from a static list (easier) or additional forms and validations if the user can pick from a list AND add new tags.

All this to say, this is half done and ready for your review. The other changes I list above will require me to carve out more brainspace and time.

@nanometrenat
Copy link
Author

Thanks, that's great to have at least the two key things that will make it easier for users to see. There's one more core scenario that we need to figure out simplest plan for. Perhaps "Place" or "Geographic" as an extra dropdown under scope? This is to cater for the following types of acronym:

  • ISO3 codes for countries
  • ISO3 codes for territories etc. that aren't countries
  • other acronyms that relate to locations - e.g. GVA, MENA etc.

Thanks

@nanometrenat
Copy link
Author

Hello hello! Loving the new scope + country being on the add/edit pages.

Should I log a separate ticket to request these fields be visible on the View acronym pages too?

  • view_acronym
  • modal on search
  • ideally on main search page as well (I would sacrifice the other languages for this, but that's just me!) If looking to save space on the search page could consider using an icon for scope and iso code for country if useful.

@katherinelilly not sure if this has become a thing for someone else these days or still JG - but tagging in case.

THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants