Add reset to defaults functionality #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasThomas
approved these changes
Oct 23, 2017
Launcher/Classes/AppHandler.swift
Outdated
|
|
||
| class AppHandler { | ||
| func applicationRestart() { | ||
| guard let resourcePath = Bundle.main.resourcePath else { exit(0) } // If we don't have a resourcePath, we can't do any restart logic |
There was a problem hiding this comment.
Let's fatalError() here with a message (instead of the exit(0))
| @@ -75,11 +75,16 @@ | |||
| <modifierMask key="keyEquivalentModifierMask"/> | |||
| <menu key="submenu" title="Settings" id="eMl-Tr-UV4"> | |||
| <items> | |||
| <menuItem title="Configure Settings" keyEquivalent="s" id="QJc-YU-Tln"> | |||
| <menuItem title="Configure settings" keyEquivalent="s" id="QJc-YU-Tln"> | |||
There was a problem hiding this comment.
Let's keep this uppercased as per the Human Interface Guidelines:
Use title-case for titles. Capitalize every word except articles, coordinating conjunctions, and prepositions of four or fewer letters.
Launcher/Classes/AppHandler.swift
Outdated
| import Foundation | ||
|
|
||
| class AppHandler { | ||
| func applicationRestart() { |
There was a problem hiding this comment.
What about restartApplication()? Reads a bit more natural.
Launcher/Classes/AppDelegate.swift
Outdated
| @@ -19,6 +19,14 @@ class AppDelegate: NSObject, NSApplicationDelegate { | |||
| } | |||
| } | |||
|
|
|||
| @IBAction func resetToDefaults(_ sender: Any) { | |||
Launcher/Classes/AppDelegate.swift
Outdated
| @@ -19,6 +19,14 @@ class AppDelegate: NSObject, NSApplicationDelegate { | |||
| } | |||
| } | |||
|
|
|||
| @IBAction func resetToDefaults(_ sender: Any) { | |||
| // Reset UserDefaults | |||
| if let appDomain = Bundle.main.bundleIdentifier { | |||
There was a problem hiding this comment.
Should we error here if the bundleIdentifier is invalid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help in testing + fixing possible user problems