Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ByteColumnType. #876

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Added ByteColumnType. #876

merged 2 commits into from
Apr 26, 2020

Conversation

spand
Copy link
Contributor

@spand spand commented Apr 14, 2020

A couple of tests are not working for me on master but I think I got a pass on all relevant tests.

@Tapac Tapac self-requested a review April 22, 2020 19:40
@Tapac
Copy link
Contributor

Tapac commented Apr 22, 2020

@spand looks like type "tinyint" does not exist in PostgreSQL.
I guess the smallint is most suitable.
https://www.postgresql.org/docs/8.2/datatype-numeric.html#DATATYPE-INT
Could you please move byte type declaration to DataTypeProvider

@spand
Copy link
Contributor Author

spand commented Apr 24, 2020

Thanks. I am unsure if the best type for Oracle actually might be NUMBER(3). Similarly I think a NUMBER(x) might be better smallint since it seems to be an alias for NUMBER(38) in Oracle.

@Tapac Tapac merged commit 63c73c8 into JetBrains:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tapac Tapac Awaiting requested review from Tapac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spand @Tapac