Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build LIMIT only if size is strictly positive #586

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Build LIMIT only if size is strictly positive #586

merged 1 commit into from
Jun 20, 2019

Conversation

jacquerie
Copy link
Contributor

AFAIK it doesn't make sense to pass a non-positive value to the LIMIT clause, so this PR prevents it from ever happening. Unfortunately I wasn't able to figure out how to write a test for this change : (

@Tapac Tapac merged commit 71ef31f into JetBrains:master Jun 20, 2019
@jacquerie jacquerie deleted the build-limit-only-if-size-is-strictly-positive branch June 21, 2019 11:51
@jacquerie
Copy link
Contributor Author

Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquerie @Tapac