Add expected improvement utility function #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| key = jr.key(42) | ||
| f = lambda x: 2.0 * jnp.sin(3 * x) + 0.5 * x | ||
| return jr.poisson(key, jnp.exp(f(x))) | ||
| return jnp.float64(jr.poisson(key, jnp.exp(f(x)))) |
There was a problem hiding this comment.
Must this be float64? If the user is using float32 arrays (ill-advised, but possible), then this will cause mixed precision errors. Can we perhaps wrap in a jnp.asarray()?
There was a problem hiding this comment.
Have switched back to returning an array of integers, as these are samples from a Poisson distribution.
thomaspinder
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
Issue Number: #459