Fixed mutable default value error in VelocityKernel and HelmholtzKernel dataclasses in python 3.11 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced direct assignments of RBF kernels in VelocityKernel dataclass with field(default_factory=...) oceanmodelling example now works with python 3.11
Replaced direct assignments of kernels in VelocityKernel and HelmholtzKernel dataclasses with field(default_factory=...) oceanmodelling example now works with python 3.11
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into GPJax!
If you have not heard from us in a while, please feel free to ping @gpjax/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on Slack for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
thomaspinder
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failurebefore committing.Description
Oceanmodelling example notebook wasn't working in python 3.11 or 3.12:
ValueError: mutable default <class 'gpjax.kernels.stationary.rbf.RBF'> for field kernel0 is not allowed: use default_factory
Fixed this issue by replacing direct assignment of kernels with field(default_factory=...). Although checked backwards compatibility with python 3.10
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.
Issue Number: N/A