Perhaps finally a decent LBFGS? #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something a bit weird happened when I updated my lock though! |
|
Looks like something has broken with the decoupled sampler? |
I managed to change the beartype version I think (when I deleted jaxopt). Fiddled the poetry files back to normal now |
|
Actually @thomaspinder its still broken. I am unable to remove the jaxopt dependency in pyproject.toml without massive changes to my poetry.lock (hence changing the beartype version). How should I be doing this? at the moment I do:
|
|
I'm not 100% sure what's going on here. Why are you running poetry update though? |
thomaspinder
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stole @daniel-dodd "back-of-the-envolope" implementation of a direct scipy minimize interface and fiddled it a bit.
It seems to work so much better (i.e. can optimize @thomaspinder's graph kernel).
Also means we can remove the jaxopt dependency