-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoke testing #307
Smoke testing #307
Conversation
very minor nit: if you actually check return values for correctness, it's not a smoke test, then it's a function integration test 😉 smoke test is just "run it and see that it doesn't blow up"... |
Ahh, interesting. I always thought they were one of the same. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @thomaspinder.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failure
before committing.Description
This PR introduces a smoke test for the regression workflow facilitated by GPJax. It asserts that the predictive mean, predictive standard deviation, MLL evaluate to ground truths.
Issue Number: #303 #304 #305