Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variational_inference.py #179

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

daniel-dodd
Copy link
Member

The quadrature function takes in standard deviation, not variance. This is a one line bug fix.

@daniel-dodd daniel-dodd added the bug Something isn't working label Jan 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Merging #179 (42cae0a) into master (3bbc8cb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          16       16           
  Lines        1473     1473           
=======================================
  Hits         1352     1352           
  Misses        121      121           
Impacted Files Coverage Δ
gpjax/variational_inference.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thomaspinder thomaspinder merged commit 3a40bac into master Jan 9, 2023
@thomaspinder thomaspinder deleted the variational_expectaion_quadrature_bug branch January 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants