-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs and test #171
Fix docs and test #171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 15 15
Lines 1425 1425
=======================================
Hits 1379 1379
Misses 46 46 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@daniel-dodd I'm going to move the docs building back to a Github workflow for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super @thomaspinder, this looks good to me.
This PR fixes some bugs within the documentation. The bugs are all hangovers from the recent update to Jax v0.4.
The PR also includes a testing job to our CircleCI workflow to ensure that all notebooks compile before using them to build the documentation site.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The docs do not currently build. Worse still, we will not know this as they are not being tested.
Issue Number: #169 #170