-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Jax/Jaxlib v0.4.x
compatibility, incorporate CircleCI testing workflows, incorporate versioneer.
#164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 96.87% 96.76% -0.11%
==========================================
Files 15 15
Lines 1407 1424 +17
==========================================
+ Hits 1363 1378 +15
- Misses 44 46 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaspinder nice PR. Left a few comments. Please in future can you fully state all features that have been added in the description, as we have not only bumped JAX, we have also integrated CircleCI and versioneer. (I have added these to the description).
One suggestion (nice have, but not requirement for this PR) I have is - do we really want all that (same) versioneer code in all repositories? It might be quite annoying to maintain?
v0.4.x
compatibility, incorporate CircleCI testing workflows, incorporate versioneer.
Apologies - I thought by merging others PRs into this one that comments would come across too. The versioneer code is autogenerated. I don't see a clean way to "share" it across packages so I'm personally fine with it as is. |
This PR:
versioneer
to determine the library version from git tags.Pull request type
What is the current behavior?
We currently:
DeviceArray
. As of Jax v0.4.1,DeviceArray
has been replaced byArray
.gpjax/__init__.py
.Issue Number: #156
New behaviour
jax.Array
's for compatibility for JAXv0.4.x
.versioneer
that automatically retrieves the package version ingpjax/__init__.py
from git tags.