-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readability and add comments. #138
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.5_update #138 +/- ##
===============================================
+ Coverage 98.27% 98.32% +0.05%
===============================================
Files 15 15
Lines 1332 1372 +40
===============================================
+ Hits 1309 1349 +40
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mean_function = self.mean_function | ||
kernel = self.kernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the advantage of this? It's only going to make stepping back through the code for new users harder.
@@ -31,11 +31,12 @@ class AbstractMeanFunction: | |||
name: Optional[str] = "Mean function" | |||
|
|||
@abc.abstractmethod | |||
def __call__(self, x: Float[Array, "N D"]) -> Float[Array, "N Q"]: | |||
def __call__(self, x: Float[Array, "N D"], params: Dict) -> Float[Array, "N Q"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where we not putting params
as the first argument?
Minor addition of comments and code readability improvements [e.g., replacing long attributes such as
self.prior.kernel(...)
withkernel = self.prior.kernel
thenkernel(...)
]. Most major changes are to the progress bar.