Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent f64 default #129

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Prevent f64 default #129

merged 1 commit into from
Nov 3, 2022

Conversation

thomaspinder
Copy link
Collaborator

Make float32 the default type, not f64.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • [ x ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently we enforce float 64. However, despite giving more stable matrix inversions, this limits reproducibility.

Issue Number: #128

What is the new behavior?

Default to float32 and set float64 in notebooks.

Other information

@thomaspinder thomaspinder added this to the v0.5.0 milestone Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #129 (fd2f974) into v0.5_update (8b02848) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v0.5_update     #129      +/-   ##
===============================================
- Coverage        98.27%   98.27%   -0.01%     
===============================================
  Files               15       15              
  Lines             1333     1331       -2     
===============================================
- Hits              1310     1308       -2     
  Misses              23       23              
Flag Coverage Δ
unittests 98.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gpjax/__init__.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thomaspinder thomaspinder merged commit 88a48dd into v0.5_update Nov 3, 2022
@thomaspinder thomaspinder deleted the f32_type branch November 3, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant