Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Matern12 kernel #119

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Fix bug in Matern12 kernel #119

merged 5 commits into from
Oct 6, 2022

Conversation

thomaspinder
Copy link
Collaborator

This PR resolves #118 by fixing the first-order Matérn kernel

Pull request type

Please check the type of change your PR introduces:

  • [ x ] Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently an incorrect 0.5 constant in the kernel's __call__ function.

Issue Number: #118

What is the new behavior?

Constant has now been removed to be consistent with the literature.

Other information

@thomaspinder thomaspinder added the bug Something isn't working label Oct 6, 2022
@thomaspinder thomaspinder added this to the v0.5.0 milestone Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #119 (5e20e1a) into master (babf010) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          13       13           
  Lines         961      961           
=======================================
  Hits          951      951           
  Misses         10       10           
Flag Coverage Δ
unittests 98.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gpjax/kernels.py 98.68% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thomaspinder thomaspinder merged commit ad8b0d5 into master Oct 6, 2022
@thomaspinder thomaspinder deleted the matern12fix branch October 16, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between docstring and implementation Matern 12
1 participant