Add verbose option. #116
Merged
Add verbose option. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,6 +178,7 @@ def fit_batches( | |||
| batch_size: int, | |||
| n_iters: Optional[int] = 100, | |||
| log_rate: Optional[int] = 10, | |||
| verbose: Optional[bool] = True, | |||
There was a problem hiding this comment.
Do you think defaulting to True is sensible? I can see benefits for defaulting to False or True, but the former feels less invasive? Keen to get your thoughts though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation of verbosity option #115 .
Tests don't check if this works or not, but only if any error occurs when turning verbosity on/off.
Training loops tests have been updated to ensure testing of edge case of a single iteration.