Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 9 support #33

Open
loucyx opened this issue Apr 15, 2024 · 11 comments
Open

ESLint 9 support #33

loucyx opened this issue Apr 15, 2024 · 11 comments

Comments

@loucyx
Copy link

loucyx commented Apr 15, 2024

Description

  • Use ESLint flat config.
  • Upgrade ESLint to version 9.
  • Run eslint with this plugin enabled.
  • An error context.getAncestors is not a function is shown because that API was deprecated.

Suggested Solution

Follow the following documentation from ESLint: https://eslint.org/docs/latest/use/migrate-to-9.0.0

@JamieMason
Copy link
Owner

Thanks @loucyx that would be great

@aeadedoyin
Copy link

Hi @JamieMason does this mean you are working it now?

@JamieMason
Copy link
Owner

I think @loucyx has everything they need there – I don't have any projects which have been upgraded to v9 so I haven't experienced that or have a project I'm using to test against, plus they have all the documentation on hand.

@loucyx
Copy link
Author

loucyx commented Apr 18, 2024

I can try to create a PR here giving your plugin compatibility with ESLint 9, but other than that the consumers of your plugin can't use it in the latest version of ESLint because it uses deprecated APIs.

@JamieMason
Copy link
Owner

Thanks @loucyx, that's great. So that way anyone on ESLint 9 can use the next version of this plugin with your changes, and anyone still on older versions of ESLint can just stay on the current version of this plugin until they're ready.

@loucyx
Copy link
Author

loucyx commented Apr 19, 2024

PR open here ☺️

@JamieMason
Copy link
Owner

Thanks a lot @loucyx 🎉 I will try to pick this up but it could be a week from now due to my availability.

@loucyx
Copy link
Author

loucyx commented Apr 19, 2024

@JamieMason of course! Take all the time you need! 😄

@tiavina-mika
Copy link

Is there any news on this?

@JamieMason
Copy link
Owner

No news just yet, my spare time at the moment is focused on syncpack, once that settles I should have some more time.

@nabato

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants