Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Internal synctex: Reveal .tex tab if open #2537

Closed
Toliak opened this issue Feb 23, 2021 · 5 comments
Closed

[Feature] Internal synctex: Reveal .tex tab if open #2537

Toliak opened this issue Feb 23, 2021 · 5 comments
Labels
enhancement Issue suggests an enhancement

Comments

@Toliak
Copy link

Toliak commented Feb 23, 2021

Is your feature request related to a problem? Please describe.
I'm always frustrated when I'm using synctex with internal PDF viewer. When I'm Ctrl+Clicking the content, source code usually opens in wrong group.

Describe the solution you'd like
I would like to expect, that source code tab will reveal, if it is already opened.

Simular feature is implemented in workbench.editor.revealIfOpen, however, this setting does not work with synctex.

Describe alternatives you've considered
Maybe there is a setting, that enables described feature. Unfortunately, I did not find it..

Additional context

image

  1. (Expected revealing existing tab)
    image

UPD:

System Info

OS: Manjaro Linux

uname -a:

Linux manjaro 5.4.97-1-MANJARO #1 SMP PREEMPT Wed Feb 10 10:24:32 UTC 2021 x86_64 GNU/Linux

VSCode version (code --version):

1.53.1
5d424b828ada08e1eb9f95d6cb41120234ef57c7
x64
@Toliak Toliak added the feature request Feature request label Feb 23, 2021
@tamuratak tamuratak added the enhancement Issue suggests an enhancement label Feb 23, 2021
@tamuratak tamuratak self-assigned this Feb 23, 2021
@jlelong
Copy link
Collaborator

jlelong commented Feb 23, 2021

It seems that removing the viewColumn argument from

vscode.window.showTextDocument(doc, viewColumn).then((editor) => {

fixes it. When no viewColumn argument is provided, the default value ViewColumn.Active is used, but its meaning is not clear to me. Yet, in this case it always reveals an already opened editor no matter the value of workbench.editor.revealIfOpen.

@tamuratak tamuratak removed their assignment Feb 23, 2021
@tamuratak
Copy link
Contributor

I have found that we cannot implement the requested feature due to the restriction of VS Code API. The same request as this issue is microsoft/vscode/issues/13639, which is forwarded to microsoft/vscode/issues/15178, which is locked as too heated.

@tamuratak tamuratak removed the enhancement Issue suggests an enhancement label Feb 23, 2021
@Toliak
Copy link
Author

Toliak commented Feb 23, 2021

Oh, ok. I'll wait for mentioned VSCode issue resolution..
Thank you for feedback!

Repository owner locked as resolved and limited conversation to collaborators Feb 23, 2021
@tamuratak
Copy link
Contributor

Reopen the issue since microsoft/vscode#15178 (comment) is going to be implemented.

@tamuratak tamuratak reopened this Sep 20, 2021
@tamuratak
Copy link
Contributor

@tamuratak tamuratak added enhancement Issue suggests an enhancement and removed feature request Feature request labels Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Issue suggests an enhancement
Projects
None yet
Development

No branches or pull requests

3 participants