-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect-port-alt@1.1.5 fails with an Error: getaddrinfo ENOTFOUND #4189
detect-port-alt@1.1.5 fails with an Error: getaddrinfo ENOTFOUND #4189
Comments
A temporary solution: Looking at create-react-app/packages/react-scripts/scripts/start.js, it appears that you can pass in environment variables: |
I couldn't get the above solution to work, so I just manually edited node_modules/detect-port-alt/lib/detect-port.js and removed the checks around return callback as shown below. |
Maybe we need to cherry-pick this fix? node-modules/detect-port@792bccd |
@greglearns most likely this is the solution! How do we help to cherry-pick that stuff into |
@Timer might find time to do it |
This will be out in 1.1.4. |
This is now released in |
Thanks! |
3: Update dependency flow-bin to v0.70.0 r=mythmon a=renovate[bot] This Pull Request updates dependency [flow-bin](https://github.com/flowtype/flow-bin) from `v0.66.0` to `v0.70.0` <details> <summary>Commits</summary> #### v0.67.1 - [`4255e2d`](flow/flow-bin@4255e2d) v0.67.1 #### v0.68.0 - [`aea9bb5`](flow/flow-bin@aea9bb5) v0.68.0 #### v0.69.0 - [`b8a5da6`](flow/flow-bin@b8a5da6) v0.69.0 #### v0.70.0 - [`0b0bcea`](flow/flow-bin@0b0bcea) v0.70.0 </details> --- This PR has been generated by [Renovate Bot](https://renovateapp.com). 4: Update dependency react-scripts to v1.1.4 r=mythmon a=renovate[bot] This Pull Request updates dependency [react-scripts](https://github.com/facebookincubator/create-react-app) from `v1.1.1` to `v1.1.4` <details> <summary>Release Notes</summary> ### [`v1.1.2`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#​112-April-3-2018) ##### 🐛 Bug Fix * `react-scripts` * [#​4085](`facebook/create-react-app#4085) Resolve `.js` before `.mjs` files to unbreak dependencies with native ESM support. ([@​leebyron]) ##### 📝 Documentation * `react-scripts` * [#​4197](`facebook/create-react-app#4197) Add troubleshooting for Github Pages. ([@​xnt]) ##### Committers: 2 - Lee Byron ([leebyron]) - Vicente Plata ([xnt]) ##### Migrating from 1.1.1 to 1.1.2 Inside any created project that has not been ejected, run: ``` npm install --save --save-exact react-scripts@​1.1.2 ``` or ``` yarn add --exact react-scripts@​1.1.2 ``` --- ### [`v1.1.3`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#​113-April-3-2018) ##### 🐛 Bug Fix * `react-scripts` * [#​4247](`facebook/create-react-app#4247) Fix `environment.dispose is not a function` error caused by a Jest bug. ([@​gaearon]) ##### Committers: 1 - Dan Abramov ([gaearon]) ##### Migrating from 1.1.2 to 1.1.3 Inside any created project that has not been ejected, run: ``` npm install --save --save-exact react-scripts@​1.1.3 ``` or ``` yarn add --exact react-scripts@​1.1.3 ``` --- ### [`v1.1.4`](https://github.com/facebookincubator/create-react-app/blob/master/CHANGELOG.md#​114-April-3-2018) ##### 🐛 Bug Fix * `react-dev-utils` * [#​4250](`facebook/create-react-app#4250) Upgrade `detect-port-alt` to fix [#​4189](`facebook/create-react-app#4189). ([@​Timer]) ##### Committers: 1 - Joe Haddad ([Timer]) ##### Migrating from 1.1.3 to 1.1.4 Inside any created project that has not been ejected, run: ``` npm install --save --save-exact react-scripts@​1.1.4 ``` or ``` yarn add --exact react-scripts@​1.1.4 ``` --- </details> <details> <summary>Commits</summary> #### v1.1.2 - [`058d03f`](facebook/create-react-app@058d03f) Fix typos in example monorepo documentation. (#​4164) - [`1922f4d`](facebook/create-react-app@1922f4d) Allow ModuleScopePlugin accecpts an array as its appSrc (#​4138) - [`33f1294`](facebook/create-react-app@33f1294) Revert "Change no-unused-vars 'args' from none to all to show warning on destructured objects" - [`8a34b7c`](facebook/create-react-app@8a34b7c) Add ESLint check for incorrect propTypes usage (#​3840) (#​4048) - [`8db5e33`](facebook/create-react-app@8db5e33) Revert lint-related changes made in #​4193 (#​4211) - [`06dd17e`](facebook/create-react-app@06dd17e) add `create-react-app --help` info for local file path `--scripts-version` support (#​4015) - [`9c167a4`](facebook/create-react-app@9c167a4) Add some stuff that requires transpilation. (#​4174) - [`da518d2`](facebook/create-react-app@da518d2) Fix floating caret position incorrect while scrolling overlay (#​4024) - [`2824bf2`](facebook/create-react-app@2824bf2) [next] Revert to use ecma 5 in uglifyOptions (#​4234) - [`9a99b5d`](facebook/create-react-app@9a99b5d) Fix typo and be clearer about `ecma` settings in uglifyjs options (#​4239) - [`9c3f03c`](facebook/create-react-app@9c3f03c) use the lastest url of gitignore file (#​4236) #### v1.1.3 - [`061d1e4`](facebook/create-react-app@061d1e4) Add troubleshooting for Github Pages (#​4197) - [`2e690e9`](facebook/create-react-app@2e690e9) Add 1.1.2 changelog (#​4242) #### v1.1.4 - [`3b102fe`](facebook/create-react-app@3b102fe) Work around Jest environment resolving bug (#​4247) - [`90c908e`](facebook/create-react-app@90c908e) Changelog for 1.1.3 - [`2762924`](facebook/create-react-app@2762924) Update detect-port-alt </details> --- This PR has been generated by [Renovate Bot](https://renovateapp.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
detect-port-alt@1.1.6 still has the bug // 1. check specified host (or null)
listen(port, host, (err, realPort) => {
// ignore random listening
if (port === 0) {
return callback(err, realPort);
}
if (err) {
return handleError(err);
}
// 2. check default host
listen(port, null, err => {
if (err) {
return handleError(err);
}
// 3. check localhost <------localhost should be optional, it depends on /etc/hosts
listen(port, 'localhost', err => {
if (err) {
return handleError(err);
} |
And what's the difference between detect-port-alt and detect-port? Why not send a PR to dectect-port? If you think it is necessary to fork detect-port so please let us know the repo address then I can make a PR for you. |
Is this a bug report?
Yes
Did you try recovering your dependencies?
Not relevant.
Which terms did you search for in User Guide?
(Write your answer here if relevant.)
Environment
node -v
: v9.7.1npm -v
: v5.6.0yarn --version
(if you use Yarn):npm ls react-scripts
(if you haven’t ejected):Then, specify:
MacOSX Sierra 10.12.6
MacOSX Sierra 10.13.3
Steps to Reproduce
(Write your steps here:)
Expected Behavior
If it's an error caused by the system configuration, it probably should suggest something meaningful.
Actual Behavior
This issue has been reported on a bunch of different repositories:
halfzebra/create-elm-app#239
node-modules/detect-port#29
The original maintainer @fengmk2 says it has been fixed in the original detect-port package.
Reproducible Demo
Not available.
The text was updated successfully, but these errors were encountered: