Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "A-Z" to translation key for group sorting #9304

Closed
koppor opened this issue Oct 24, 2022 · 5 comments
Closed

Add "A-Z" to translation key for group sorting #9304

koppor opened this issue Oct 24, 2022 · 5 comments
Assignees
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Oct 24, 2022

Here is the corresponding line

MenuItem sortSubgroups = new MenuItem(Localization.lang("Sort subgroups"));
sortSubgroups.setOnAction(event -> viewModel.sortAlphabeticallyRecursive(group.getGroupNode()));

From Localization.lang("Sort subgroups")); to Localization.lang("Sort subgroups A-Z"));

The JabRef_en.properties files needs to be adjusted then as well. The other files are handled by Crowdin.

Originally posted by @Siedlerchr in #9248 (comment)

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 24, 2022
@Aditya31398
Copy link
Contributor

Hi @koppor, I am a first timer. Can I work on this?

@ThiloteE ThiloteE added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 26, 2022
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@Aditya31398
Copy link
Contributor

@ThiloteE, can you brief over the issue. Is the change required only in the line mentioned above? What changes are required in the JabRef_en.properties

@ThiloteE
Copy link
Member

The change is required in two places: 1. in the line above and 2. in JabRef_en.properties

I have never done anything related to translations before, so I am not too sure. As far as I understand it, JabRef is English native and all translations are based on JabRef's English localization, which would be JabRef_en.properties. If you change the English localization, it will trigger a change (or request to change?) the other languages as well. Correct me, if I am wrong. So, if you were to only change the above line, then only the code would be renamed, but users of JabRef would not notice, because this change would not be transmitted to JabRef's user interface.

What changes are required? Simply rename Sort subgroups to Sort subgroups A-Z.

@Aditya31398 Aditya31398 mentioned this issue Oct 26, 2022
6 tasks
@Aditya31398
Copy link
Contributor

Aditya31398 commented Oct 26, 2022

Hi @ThiloteE, I have created a PR for this issue with the changes mentioned above. Can you verify if the changes are good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

No branches or pull requests

3 participants