Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results not updated after import #1513

Closed
tobiasdiez opened this issue Jun 26, 2016 · 6 comments
Closed

Search results not updated after import #1513

tobiasdiez opened this issue Jun 26, 2016 · 6 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs maintable search

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Jun 26, 2016

JabRef version latest dev on Windows 10

Steps to reproduce:

  1. Search for something, say "test"
  2. Import an entry which would be matched by the search (say it was written by the author "test")
  3. View is not updated to incorporate new hit
  4. Also not updated after pasting a new entry
@tobiasdiez tobiasdiez added the bug Confirmed bugs or reports that are very likely to be bugs label Jun 26, 2016
@AEgit
Copy link

AEgit commented Jul 31, 2016

JabRef 3.6dev--snapshot--2016-07-29--fix1639--e838541
windows 10 10.0 amd64
Java 1.8.0_101

I guess the following problem is related to this (otherwise I would have to open a new issue):

Steps to reproduce:

  1. Turn on "Gray out non-hits"
  2. Search for something, e.g. "test" and select an entry, that is assigned to a (static) group
  3. Drag'n'drop this entry to another (static) group, i. e. assign the entry to another group to which it hadn't been assigned to before
  4. View is not updated to incorporate the new assignment of the entry, i. e. when selecting the group to which the entry has newly been assigned to, the entry is still marked in gray as a "non-hit"
  5. If you save your change, close Jabref, reopen it and then select the respective group, the newly assigned entry is now found among the hits/ is white. That means, that the new group assignment actually works, it's just the view that is not updated properly.

@tobiasdiez
Copy link
Member Author

This should be fixed in the latest development version. Could you please check the build from https://builds.jabref.org/maintable-beta/. Thanks! Note this version is in a very early beta stage and might not work as expected. See #3621 for further details.

@AEgit
Copy link

AEgit commented Jan 30, 2018

Cannot confirm for (see comment below):

JabRef 4.2-dev--snapshot--2018-01-30--maintable-beta--85342350f
Windows 10 10.0 amd64
Java 1.8.0_161

I cannot test, whether the actual bug has been fixed, as graying out non-hits does not seem to work anymore (it is selected in Preferences -> Groups), but it does not seem to have any effect. Instead of graying out non-hits, they are just not shown. It seems that the option "Hide non-hits" is now always active.

Furthermore, it seems to me, that the performance of the search has dropped again for large databases (> 10,000 entries).

@tobiasdiez
Copy link
Member Author

@AEgit Thanks for the feedback. The "gray out non-hits" feature does indeed no longer work and will probably removed completely.

I'll have a look at the performance problems.

@AEgit
Copy link

AEgit commented Jan 30, 2018

@tobiasdiez Would it require a lot of additional work to keep the "gray out non-hits" feature? To be honest, I've always used that feature a lot, as it sometimes helps you spot items (e.g., because they contain a certain keyword that matches the search) that should already belong to a certain group (containing the keyword) but still have not been assigned to.

@matthiasgeiger
Copy link
Member

I'm also in favor of keeping the float mode, as this is also the setting I prefer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs maintable search
Projects
None yet
Development

No branches or pull requests

4 participants