Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser extension import not working #479

Closed
2 tasks
Tobi0 opened this issue Jul 8, 2022 · 2 comments · Fixed by Tobi0/jabref#1 or JabRef/jabref#8965
Closed
2 tasks

Browser extension import not working #479

Tobi0 opened this issue Jul 8, 2022 · 2 comments · Fixed by Tobi0/jabref#1 or JabRef/jabref#8965
Labels
env:win Specific to Windows type:bug

Comments

@Tobi0
Copy link

Tobi0 commented Jul 8, 2022

JabRef version

5.6 (latest release)

Operating system

Windows

Details on version and operating system

Windows 10 20H2 19042.1706

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

This seems to occur on Windows only if pwsh.exe is not installed, but powershell.exe installed.

Issue

The Jabref Browser Extension (Firefox) shows "Error while sending to JabRef" and no reaction from the client at all (either opened or not).

Possible Cause

This change on buildres/windows/JabRefHost.bat: JabRef/jabref#8432
There is probably an issue with the errorlevel check.
If I change the file back to only the @powershell.exe command, it works.

Appendix

...

Log File
Paste an excerpt of your log file here
@ThiloteE ThiloteE transferred this issue from JabRef/jabref Jul 9, 2022
@ThiloteE ThiloteE added type:bug env:win Specific to Windows and removed type: bug 🐛 labels Jul 9, 2022
@ThiloteE
Copy link
Member

ThiloteE commented Jul 9, 2022

The transfer from JabRef/JabRef to JabRef/JabRef-Browser-Extension created new labels "type bug" and "os:windows", which i can't get rid off. Sorry :/

@tobiasdiez
Copy link
Member

Thanks for the investigation @Tobi0! I think you are right, the second %errorlevel% does not reflect the outcome of the second test. In fact, a similar question has been raised here https://stackoverflow.com/questions/50348437/wrong-value-of-errorlevel-in-nested-if-in-bat-file. Could you please try the workaround/fix posted there, and if it indeed works open a PR at the jabref repo? That would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:win Specific to Windows type:bug
Projects
None yet
4 participants