Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require re-saving cuts before calibration if beam settings have been changed #98

Open
tpitkanen opened this issue Nov 24, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@tpitkanen
Copy link
Member

tpitkanen commented Nov 24, 2020

Problem

ToF calibration can be accessed with stale .cut files if beam settings are changed without generating new cuts.

(This is an old bug. This issue was based on an email bug report.)

Reproduction

  1. Create a request
  2. Import measurement data
  3. Make selections and save cuts that are RBS
  4. Change beam settings (e.g. beam element)
  5. Apply settings
  6. Do Detector > Calibration > Execute
  7. Observe that affected RBS cuts have the old beam in their name
@tpitkanen tpitkanen added the bug Something isn't working label Nov 24, 2020
@tpitkanen
Copy link
Member Author

Workaround in c015910

@tpitkanen tpitkanen mentioned this issue Nov 24, 2020
@tpitkanen
Copy link
Member Author

tpitkanen commented Nov 24, 2020

This could be solved by keeping track of cut files and their staleness. There are probably other good uses for such feature.

Offering an option to re-save cuts for all measurements that use default settings after changing beam settings is a feasible option too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant