Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule JIBAL #283

Closed
samivout opened this issue May 3, 2023 · 2 comments
Closed

Update submodule JIBAL #283

samivout opened this issue May 3, 2023 · 2 comments
Assignees

Comments

@samivout
Copy link
Collaborator

samivout commented May 3, 2023

Update Potku's submodule JIBAL to its newest version and add support for it in Potku.

@samivout samivout self-assigned this May 3, 2023
@samivout
Copy link
Collaborator Author

samivout commented May 3, 2023

This is functional at least on Windows. Linux and Mac functionality should still be tested, as the commandline argument order for jibaltool might be different for the other operating systems.

@jaakkojulin
Copy link
Member

The implemented order of command line arguments should work on Linux and MacOS. Testing is still strongly encouraged.

It might also make sense to check that the return value of running jibaltool (Popen.returncode? or subprocess.run(..., check=True) is zero (success) or use some other check to see that jibaltool runs correctly, unless the output parsing already handles this, in which case feel free to ignore this suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants