Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reference density in Profile #241

Open
tpitkanen opened this issue Jan 12, 2022 · 1 comment
Open

Rename reference density in Profile #241

tpitkanen opened this issue Jan 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tpitkanen
Copy link
Member

RecoilElement and Profile both have a reference_density member variable, but they are unrelated, which is confusing. The reference_density in RecoilElement is more important, so the one in Profile should probably be renamed.

If the variable is renamed, settings file backwards compatibility will break (unless the variable is renamed when reading/saving the file). Because this is a minor change, it should only be done when there are other changes to the file formats.
@tpitkanen tpitkanen added the enhancement New feature or request label Jan 12, 2022
@tpitkanen tpitkanen mentioned this issue Jan 17, 2022
Merged
@tpitkanen tpitkanen mentioned this issue Jan 25, 2022
Closed
@jkpnen jkpnen mentioned this issue Jan 26, 2022
Closed
@tpitkanen
Copy link
Member Author

I noticed that the RecoilElement default reference_density is currently defined in Profile:

potku/modules/profile.py

Line 39 in f7c499b

REFERENCE_DENSITY = 4.98e22

It should be moved to RecoilElement (or Simulation).

@tpitkanen tpitkanen mentioned this issue Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpitkanen