Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted elements aren't deleted from sum spectra #222

Open
tpitkanen opened this issue Nov 22, 2021 · 2 comments · Fixed by #232
Open

Deleted elements aren't deleted from sum spectra #222

tpitkanen opened this issue Nov 22, 2021 · 2 comments · Fixed by #232
Labels
bug Something isn't working

Comments

@tpitkanen
Copy link
Member

If an element that is in a sum energy spectrum is deleted, the sum spectrum stays unchanged. Nothing calls SumEnergySpectrum.delete_spectra(...).
@tpitkanen tpitkanen added the bug Something isn't working label Nov 22, 2021
@jkpnen jkpnen mentioned this issue Nov 25, 2021
Merged
3 tasks
@jkpnen
Copy link
Contributor

jkpnen commented Jan 11, 2022

@tpitkanen , are there currently any events where this feature would have been desired?

@tpitkanen
Copy link
Member Author

tpitkanen commented Jan 11, 2022 •
edited

@tpitkanen , are there currently any events where this feature would have been desired?

The use cases are the same as in #230. Whenever an element is removed, the change should be reflected in the user interface (a removed element should be deleted from the espe plot, and it should also trigger an update in a sum spectrum).

@tpitkanen tpitkanen reopened this Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sum spectrum issues jkpnen/potku
2 participants
@tpitkanen @jkpnen