Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There seems to be an error in the code #28

Open
Dongber opened this issue Feb 27, 2023 · 2 comments
Open

There seems to be an error in the code #28

Dongber opened this issue Feb 27, 2023 · 2 comments

Comments

@Dongber
Copy link

Dongber commented Feb 27, 2023

In line 460 of READ.gl.utils, it should be 'model['normals'] = np.zeros((n_pts, 3), dtype=np.float32)'. Is this an error?

@JOP-Lee
Copy link
Owner

JOP-Lee commented Feb 28, 2023

Thanks for pointing out the error, this part of the code is using NPBG. In our work, point clouds have normals, so it doesn't matter

@booker-max
Copy link

Thanks for pointing out the error, this part of the code is using NPBG. In our work, point clouds have normals, so it doesn't matter

  1. When I run the pointcloud.ply file you provided, there is no normals is this file, I think you better confirm
  2. In the utils.py, you write
    " if model['normals'] is None:
    print(f'no normals in {model_path}')
    model['rgb'] = np.zeros((n_pts, 3), dtype=np.float32)"
    I think this is wrong, it should be model["normals"] = np.zeros((n_pts, 3), dtype=np.float32)", because we have already defined model["rgb"] before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants