Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector3d.div() incorrectly takes in Vector3d instead of Vector3dc #339

Closed
theagentd opened this issue Jul 15, 2023 · 1 comment
Closed

Comments

@theagentd
Copy link

Tiny bug I stumbled upon today.

    public Vector3d div(Vector3d v) {
        this.x = x / v.x();
        this.y = y / v.y();
        this.z = z / v.z();
        return this;
    }

This function does not modify v, so it should be taking in a Vector3dc. :)

@httpdigest
Copy link
Member

httpdigest commented Jul 15, 2023

Hi @theagentd,
this (and other occurrences) have already been fixed with 03cbd5e (original PR: #323) (though not released yet, but available since December 2022 as 1.10.6-SNAPSHOT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants