Skip to content

Commit

Permalink
fix the code scanning security advisory 2 and adding more info on the…
Browse files Browse the repository at this point in the history
… render-process-gone (#1380)
  • Loading branch information
IsmaelMartinez authored Aug 23, 2024
1 parent 53971e3 commit 916ec82
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
5 changes: 3 additions & 2 deletions app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,9 @@ async function playNotificationSound(_event, options) {
console.debug('No notification sound played', player, options);
}

function onRenderProcessGone() {
console.debug('render-process-gone');
function onRenderProcessGone(event, details) {
console.error(`render-process-gone with reason: '${details.reason}'.`);
console.error(`Event '${event}' and details '${details}'`);
app.quit();
}

Expand Down
2 changes: 1 addition & 1 deletion app/mainAppWindow/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ function restoreWindow() {

function processArgs(args) {
const v1msTeams = /^msteams:\/l\/(?:meetup-join|channel)/g;
const v2msTeams = /^msteams:\/\/teams.microsoft.com\/l\/(?:meetup-join|channel)/g;
const v2msTeams = /^msteams:\/\/teams\.microsoft\.com\/l\/(?:meetup-join|channel)/g;
console.debug('processArgs:', args);
for (const arg of args) {
console.debug(`testing RegExp processArgs ${new RegExp(config.meetupJoinRegEx).test(arg)}`);
Expand Down
8 changes: 8 additions & 0 deletions com.github.IsmaelMartinez.teams_for_linux.appdata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@
<url type="bugtracker">https://github.com/IsmaelMartinez/teams-for-linux/issues</url>
<launchable type="desktop-id">com.github.IsmaelMartinez.teams_for_linux.desktop</launchable>
<releases>
<release version="1.9.5" date="2024-08-23">
<description>
<ul>
<li>Fix Incomplete regular expression for hostnames for github scanning in ms teams url</li>
<li>Printing the render-process-gone reason to help analyse #1369</li>
</ul>
</description>
</release>
<release version="1.9.4" date="2024-08-23">
<description>
<ul>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "teams-for-linux",
"version": "1.9.4",
"version": "1.9.5",
"main": "app/index.js",
"description": "Unofficial client for Microsoft Teams for Linux",
"homepage": "https://github.com/IsmaelMartinez/teams-for-linux",
Expand Down

0 comments on commit 916ec82

Please sign in to comment.