Issues #11
Merged
Issues #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved some complications issues. The kotlin plugin in intellij is not compatiable with gradle plugin projects using the kotlin-dsl gradle plugin.
…eprecated on Docker Desktop.
We can't reliably assume that the image/tag actually corresponds to the same inputs when switch between changes we already built before. As gradle happy places the generated digest.json file and ignores that the tagged image hasn't actually been changed. This is because gradle isn't actually tracking the generated image but rather its approximate digest. So the tag can point to the previous build when switching between two sets of changes for which gradle has a cached output.
|
I've tested the changes against the main branch of buildkit all seems well. |
dannylamb
approved these changes
Jul 9, 2021
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues #9 and #10, and makes changes that will allow us to get the plugin hosted at https://plugins.gradle.org/. This will allow us to use build scans, and should make builds slightly faster.