-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin #123
Merged
Merged
Update plugin #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should merge this before hand: Islandora-Devops/isle-gradle-docker-plugin#7 |
nigelgbanks
force-pushed
the
update-plugin
branch
from
March 23, 2021 12:39
3980ddf
to
f429178
Compare
Drops support for non-buildkit builds. Adds the following: - multi-arch builds (amd64, arm64, etc) - custom build of confd to support arm64 - unique build caches per image (should reduce cache misses) - fixes fits (mediainfo, exifdata, file info) - update gradle version to latest (match plugin) - child images of tomcat can override tomcat properties - child images of nginx can override php/nginx properties - updated to use latest alpine 3.13 - php is no 7.4 - imagemagick only builds what is required (no longer make clibs, etc) - general refactors
When not pushing to remote repository so use the default builder instead for pull requests.
nigelgbanks
force-pushed
the
update-plugin
branch
from
March 23, 2021 15:40
c58575d
to
e468dd9
Compare
I tried building and I got this: danny@danny-XPS-13-7390:~/Code/Islandora/isle-buildkit$ ./gradlew build
Downloading https://services.gradle.org/distributions/gradle-6.8.3-bin.zip
..........10%..........20%..........30%...........40%..........50%..........60%..........70%...........80%..........90%..........100%
Welcome to Gradle 6.8.3!
Here are the highlights of this release:
- Faster Kotlin DSL script compilation
- Vendor selection for Java toolchains
- Convenient execution of tasks in composite builds
- Consistent dependency resolution
For more details see https://docs.gradle.org/6.8.3/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Task :isle-gradle-docker-plugin:compileKotlin FAILED
e: /home/danny/Code/Islandora/isle-buildkit/.gradle/vcs-1/isle-gradl_9a6ae2w5ycft6mz6c3jekfhpo/isle-gradle-docker-plugin/src/main/kotlin/tasks/DockerBuild.kt: (8, 53): Symbol is declared in module 'java.xml' which does not export package 'com.sun.org.apache.xpath.internal.operations'
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':isle-gradle-docker-plugin:compileKotlin'.
> Compilation error. See log for more details
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 5s I'm trying to debug but I'm not sure how to tell if I'm getting the right version of the plugin or if maybe i'm using an older cached version. |
This appears to be working fine after some basic tests using isle-dc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for non-buildkit builds. Adds the following: