This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Provides support for remote database access. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannylamb
reviewed
Jan 31, 2020
| @@ -14,4 +14,7 @@ __crayfish_packages: | |||
| - tesseract-langpack-srp | |||
| - ffmpeg | |||
| - poppler-utils | |||
| - python-psycopg2 | |||
| - python-mysqldb | |||
There was a problem hiding this comment.
Should be MySQL-python instead of python-mysqldb and mysql instead of mysql-client for CENTOS.
dannylamb
suggested changes
Jan 31, 2020
There was a problem hiding this comment.
Other than the package names for CENTOS, this totally works. However, you need to update your branch with changes from upstream, as it currently is missing what it needs to deploy Houdini. Took me a while to figure out the changes weren't on your branch, b/c just by looking at the PR it shouldn't be an issue.
|
@dbernstein @dannylamb i pulled in this PR, made the 2 package name changes, and was able to deploy with Gemini database hosted in AWS RDS. if this is updated, i can give an official review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: N/A
Release pull requests, etc.)
What does this Pull Request do?
It allows the crayfish database to live on a non-local database server.
What's new?
The parameters that allow for remote database creation and connection.
How should this be tested?
Set up a remote database server and specify the necessary parameter overrides.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers