Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate authority fields #13

Merged
merged 1 commit into from
Nov 1, 2018
Merged

consolidate authority fields #13

merged 1 commit into from
Nov 1, 2018

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: Islandora/documentation/issues/963

What does this Pull Request do?

Consolidates the various authority link fields into a single term storage and consistent field name to make it easier to search across term vocabularies using a given URI.

What's new?

  • Added field_authority_link
  • Removed the other authority_link fields
  • Could this change impact execution of existing code? Shouldn't; nothing is using these fields yet.

How should this be tested?

  • apply the PR
  • enable controlled_access_terms_default_configuration (it shouldn't complain about missing configs or dependencies).
  • make some new terms with external uris
  • Optional: after you make some terms with external URIs, use drush to search for them; e.g.
drush php:eval "print_r(\Drupal::entityManager()->getStorage('taxonomy_term')->loadByProperties(['field_authority_link'=>'http://example_uri']));"

Interested parties

@Islandora-CLAW/committers

@seth-shaw-unlv
Copy link
Contributor Author

I should also note that you only need a vanilla Drupal install to test.

dannylamb
dannylamb approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dannylamb dannylamb merged commit cc85dea into 8.x-1.x Nov 1, 2018
@seth-shaw-unlv seth-shaw-unlv deleted the consolidate-fields branch November 1, 2018 15:21
@dannylamb dannylamb mentioned this pull request Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannylamb dannylamb dannylamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seth-shaw-unlv @dannylamb